Fix next_sync_committe validation for light client
#2806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #2746 introduced a regression in the validation of the `next_sync_committee` where the corresponding merkle proof is computed based on an incorrect state root. `next_sync_committee` is always rooted in the attested header, even for a `LightClientUpdate` that includes a `finalized_header`.
|
After further review, this seems to not have been a regression. For finalized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2746 introduced a
regression in the validation of the
next_sync_committeewhere thecorresponding merkle proof is computed based on an incorrect state root.
next_sync_committeeis always rooted in the attested header, even fora
LightClientUpdatethat includes afinalized_header.