add resourceunavailable error code with more guidance #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
force-pushed
the
resource-unavailable
branch
from
8d4d68b
to
48d76ea
Compare
djrtwo
force-pushed
the
resource-unavailable
branch
from
48d76ea
to
5bf01c4
Compare
protolambda
reviewed
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ResourceUnavailableback in with explicit guidance that it is currently only a valid response forBlocksByRangeand also that such unsynced nodesSHOULDrespond using it.Conversations on #2414 debate if/how this should be inserted. The crux is that some teams think the extra information will be valuable whereas others think it is only cumbersome without reducing complexity. I think the restricted use in this PR is a reasonable compromise.
Additionally for any client that finds the introduction of this error case as cumbersome/complex, I suggest that the receiving of this error code just gets put into the already existing
if bad_block_range_response()control flow. If the information is indeed not valuable, it can easily just be lumped into the existing "bad response" code.