Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note in validator guide about slashing and exit operation interaction #2103

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Oct 14, 2020

addresses #2084.

  • add note about the interaction between slashings and voluntary exits of the same index in the same block
  • add block tests for a few conditions

note added new test_multi_operation.py testfile that outputs block tests. We are lacking in interesting/complex block tests with operations of multiple/many types. I plan to add a number of tests here in the following week

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An issue of the test format, otherwise LGTM!

@djrtwo djrtwo merged commit 2c337d6 into v1.0-candidate Oct 16, 2020
@djrtwo djrtwo deleted the slash-exit branch October 16, 2020 14:39
@djrtwo djrtwo mentioned this pull request Oct 20, 2020
@lucianyao
Copy link

lucianyao commented Oct 21, 2020

Hi @hwwhww , I have seen it was committed to v1.0-candidate, while the default is the dev, I would like to know which branch is the canonical spec for implementer to follow?thanks!

@hwwhww
Copy link
Contributor

hwwhww commented Oct 21, 2020

@lucianyao They both are.

  • v1.0-candidate is the branch for the incoming spec v1.0.0, now only accepts critical fixes or test vector updates.
  • dev is currently serving the non-phase-0-launch PRs. e.g., phase 1 specs
  • master is the release tags branch.

I suppose @djrtwo will merge v1.0-candidate into master and cut 1.0.0, and then backport master to dev. If you're finding phase 0 issues, I suggest you look at v1.0-candidate branch. Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants