Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump IETF BLS spec version draft 03 -> draft 04 #2080

Merged
merged 6 commits into from
Oct 5, 2020
Merged

Bump IETF BLS spec version draft 03 -> draft 04 #2080

merged 6 commits into from
Oct 5, 2020

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Sep 25, 2020 •
edited
Loading

Address #2072

TODOs

  • Bump py_ecc to BLSv4 version
  • Bump milagro_bls_binding to BLSv4 version

djrtwo
djrtwo reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@djrtwo djrtwo changed the base branch from dev to v1.0-candidate September 28, 2020 19:02
@djrtwo
Copy link
Contributor

djrtwo commented Sep 28, 2020

I modified this to point to v1.0-candidate. Separate from dev so that we can cleanly patch v0.12 in the next few days if needbe

@djrtwo djrtwo mentioned this pull request Sep 28, 2020
Merged
7 tasks
mratsim
mratsim approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@mratsim mratsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@hwwhww hwwhww marked this pull request as ready for review October 5, 2020 12:58
@hwwhww
Copy link
Contributor Author

hwwhww commented Oct 5, 2020

Two pending issues of milagro:

I added some edge case handler in pyspec utils tests/core/pyspec/eth2spec/utils/bls.py for getting test generator ready ASAP. Once the pending issues are fixed, we can bump the next milagro_bls_binding version soon.

/cc @ChihChengLiang @kirk-baird @djrtwo

@hwwhww hwwhww merged commit d264ad8 into v1.0-candidate Oct 5, 2020
@hwwhww hwwhww deleted the bls_v4 branch October 5, 2020 14:18
@hwwhww hwwhww mentioned this pull request Oct 6, 2020
Merged
mratsim added a commit to status-im/nim-blscurve that referenced this pull request Oct 26, 2020
@mratsim
Rework BLSv4 API ethereum/consensus-specs#2080 and address #76 #77
4d9674b
@mratsim mratsim mentioned this pull request Oct 26, 2020
Merged
mratsim added a commit to status-im/nim-blscurve that referenced this pull request Oct 26, 2020
@mratsim
BLS signature v4 (#91)
3878b9b 
* Update vectors to BLSv4 v1.0.0-rc0 [skip ci]

* Workaround ethereum/consensus-spec-tests#22, ethereum/consensus-specs#2099

* Rework BLSv4 API ethereum/consensus-specs#2080 and address #76 #77

* Upgade Milagro vectors

* Upgrade BLST backend with new API

* BLST forgot to return true for publicFromSecret
@mratsim mratsim mentioned this pull request Oct 26, 2020
Merged
@hwwhww hwwhww mentioned this pull request Nov 4, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo left review comments

@melyalex melyalex melyalex approved these changes

@mratsim mratsim mratsim approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE scope:BLS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hwwhww @djrtwo @mratsim @melyalex