Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ShardBlockHeader hash tree root as the shard block root #1975

Closed
wants to merge 2 commits into from
Closed

Use ShardBlockHeader hash tree root as the shard block root #1975

wants to merge 2 commits into from

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Jul 20, 2020

Address #1973

This PR adds compute_shard_block_header_root helper to compute the shard block root with ShardBlockHeader.

@hwwhww hwwhww added the phase1 label Jul 20, 2020
@hwwhww hwwhww changed the title Use ShardBlockHeader.body_root as the shard block root Use ShardBlockHeader hash tree root as the shard block root Jul 20, 2020
This was referenced Jul 21, 2020
Closed
Merged
@hwwhww
Copy link
Contributor Author

hwwhww commented Jul 22, 2020

Replaced by #1980

@hwwhww hwwhww closed this Jul 22, 2020
@hwwhww hwwhww deleted the hwwhww/fix-header-body-root branch July 29, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
phase1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hwwhww