Add unit tests for compute_fork_digest and compute_subnet_for_attestation
#1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
approved these changes
Jun 16, 2020
Comment on lines
+322
to
+324
| expected_fork_data_root = spec.hash_tree_root( | ||
| spec.ForkData(current_version=state.fork.current_version, | ||
| genesis_validators_root=state.genesis_validators_root)) |
There was a problem hiding this comment.
nitpicking tip: can just use
Suggested change
| expected_fork_data_root = spec.hash_tree_root( | |
| spec.ForkData(current_version=state.fork.current_version, | |
| genesis_validators_root=state.genesis_validators_root)) | |
| expected_fork_data_root = spec.compute_fork_data_root( | |
| current_version=state.fork.current_version, | |
| genesis_validators_root=state.genesis_validators_root, | |
| ) |
There was a problem hiding this comment.
Ah true! I wanted to cover testing compute_fork_data_root here too b/c I didn't see a test for that, but I suppose it's a better practice to just test 1-level down.
|
Thank you for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1865