Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify BlocksByRange request #1795

Merged
merged 2 commits into from
May 11, 2020
Merged

Clarify BlocksByRange request #1795

merged 2 commits into from
May 11, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented May 8, 2020

address #1765

@djrtwo djrtwo changed the base branch from dev to v012x May 8, 2020 17:11
@djrtwo djrtwo requested a review from protolambda May 8, 2020 17:11
protolambda
protolambda approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djrtwo djrtwo merged commit ca1876e into v012x May 11, 2020
@djrtwo djrtwo deleted the clarify-blocks-request branch May 11, 2020 17:39
@terencechain terencechain mentioned this pull request May 20, 2020
Closed
25 tasks
@paulhauner paulhauner mentioned this pull request May 21, 2020
Closed
22 tasks
@nisdas nisdas mentioned this pull request May 22, 2020
Merged
@ColinSchwarz ColinSchwarz mentioned this pull request May 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

Assignees
No one assigned
Labels
scope:networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djrtwo @protolambda @hwwhww