genesis: clarify that eth1 timestamp can be less than min genesis time #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Funny, without looking at the spec, I would have guessed this operated as it did in lighthouse.
I think this silently got changed a while back when we changed the mechanics on how potential genesis states were produced and checked.
That said, the current spec makes the semantics of MIN_GENESIS_TIME more correct.
Thanks!
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref prysmaticlabs/prysm#5616 sigp/lighthouse#1051