Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling out some of the cosmetic changes from #1737:
SigningRoot
container toSigningData
. Thesigning_root
(of typeRoot
) is thehash_tree_root
of theSigningData
(of typeContainer
).compute_signing_root
(The rationale for this split is because the substantive changes from #1737 may not make it in phase 0. Also this will help focus the discussion in #1737 on the substantive changes.)