Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subnet validations for DoS resistance #1615

Merged
merged 9 commits into from
Feb 12, 2020
Merged

Add subnet validations for DoS resistance #1615

merged 9 commits into from
Feb 12, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Feb 11, 2020 •
edited
Loading

Addresses #1595

Quick details for clarity on what was added/changed:

  • beacon_block
    • prevent multiple beacon blocks from same proposer in a slot
  • committee_index_beacon_attestation
    • prevent multiple attestations from same participant in a slot
  • aggregate_and_proof
    • aggregator signs aggregate_and_proof and broadcasts SignedAggregateAndProof. verify this signature in addition to the proof and attestation sig
    • prevent multiple aggregate_and_proofs from same aggregator in a slot
    • add DOMAIN_SELECTION_PROOF and DOMAIN_AGGREGATE_AND_PROOF
    • add explicit instructions in validator guide for signing these messages
  • reorder gossip conditions to put signature verifications after the cheap checks

@djrtwo djrtwo force-pushed the subnet-validations branch from 89c33b1 to 8a2a689 Compare February 11, 2020 02:36
@djrtwo djrtwo requested a review from protolambda February 11, 2020 02:38
@djrtwo
Copy link
Contributor Author

djrtwo commented Feb 11, 2020

cc @AgeManning @mkalinin
Thanks for the input on the issue. Take a look here if you have a moment

protolambda
protolambda reviewed Feb 11, 2020
View reviewed changes
specs/phase0/p2p-interface.md Outdated Show resolved Hide resolved
specs/phase0/p2p-interface.md Outdated Show resolved Hide resolved
@protolambda protolambda added the scope:DoS protection Protect the network from Denial of Service attacks. label Feb 11, 2020
hwwhww
hwwhww reviewed Feb 11, 2020
View reviewed changes
specs/phase0/p2p-interface.md Outdated Show resolved Hide resolved
specs/phase0/p2p-interface.md Outdated Show resolved Hide resolved
specs/phase0/validator.md Show resolved Hide resolved
@djrtwo djrtwo force-pushed the subnet-validations branch from 700d87c to 9198433 Compare February 11, 2020 22:50
@djrtwo djrtwo force-pushed the subnet-validations branch from 9198433 to 9047638 Compare February 11, 2020 22:54
hwwhww
hwwhww approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@djrtwo djrtwo merged commit a9fae27 into dev Feb 12, 2020
@djrtwo djrtwo deleted the subnet-validations branch February 12, 2020 19:02
@djrtwo djrtwo mentioned this pull request Feb 12, 2020
Closed
This was referenced Mar 20, 2020
Merged
Merged
Closed
@ColinSchwarz ColinSchwarz mentioned this pull request Mar 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda left review comments

@mkalinin mkalinin mkalinin left review comments

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
scope:DoS protection Protect the network from Denial of Service attacks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djrtwo @mkalinin @hwwhww @protolambda