Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed refactor of compact committees #1318

Closed
wants to merge 1 commit into from
Closed

Conversation

vbuterin
Copy link
Contributor

NOT substantive.

Goal is to abstract out the committee to compact committee transformation to allow it to be used for persistent committees as well.

NOT substantive.

Goal is to abstract out the committee to compact committee transformation to allow it to be used for persistent committees as well.
@JustinDrake
Copy link
Contributor

Did we come to the conclusion that crosslink committee roots (as well as active validator indices) are not required? Lots of saved hashing.

@vbuterin
Copy link
Contributor Author

I think so! In which case the right thing to do would be to remove the compact committee logic entirely and move it into the phase 1 spec?

Also, what's the appropriate place to put beacon chain changes in the phase 1 spec that are NOT proof of custody related? (as eg. the persistent committee roots would be)

@JustinDrake
Copy link
Contributor

the right thing to do would be to remove the compact committee logic entirely and move it into the phase 1 spec

I think so. And making light clients clearly fall into phase 1 is a nice conceptual cleanup :)

what's the appropriate place to put beacon chain changes in the phase 1 spec that are NOT proof of custody related?

As suggested by @protolambda here we can have 1_misc-beacon-updates.md complementing 1_custody-game.md. This document would add light client infrastructure, transfers, and make miscellaneous changes like removing assert data.crosslink.data_root == Bytes32().

@vbuterin vbuterin closed this Jul 30, 2019
@djrtwo djrtwo deleted the vbuterin-patch-10 branch May 20, 2020 23:11
@djrtwo djrtwo restored the vbuterin-patch-10 branch May 20, 2020 23:11
@djrtwo djrtwo deleted the vbuterin-patch-10 branch May 20, 2020 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants