Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale inclusion reward properly #1257

Merged
merged 1 commit into from
Jul 1, 2019
Merged

scale inclusion reward properly #1257

merged 1 commit into from
Jul 1, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jul 1, 2019

Inclusion reward was too aggressive scaling down. This happened in a "clean up" PR a long time ago.

@djrtwo djrtwo requested a review from hwwhww July 1, 2019 03:46
@protolambda
Copy link
Collaborator

protolambda commented Jul 1, 2019

Do we need to adjust epoch slot down, to make 63/63 a thing? I.e. run up to 100% linearly from 0.

@protolambda
Copy link
Collaborator

protolambda commented Jul 1, 2019

This 64/64 works too. But results in 1/64 minimum.

Edit: was convinced, now that it's a reward and not a penalty, it's ok to give a non 0 minimum.

@djrtwo
Copy link
Contributor Author

djrtwo commented Jul 1, 2019

The 1/64 minimum is good because they did manage to get their attestation on chain so some reward for inclusion. imo

@djrtwo djrtwo merged commit 4ea79ee into dev Jul 1, 2019
@djrtwo djrtwo deleted the scale-inclusion-reward branch July 1, 2019 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants