Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove bounds check in compute_shuffled_index and Fix ToC #1252

Merged
merged 2 commits into from
Jul 1, 2019
Merged

remove bounds check in compute_shuffled_index and Fix ToC #1252

merged 2 commits into from
Jul 1, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Jul 1, 2019 •
edited by djrtwo
Loading

Bounds check enforced by state.validators SSZ List limit

@hwwhww hwwhww added the milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet label Jul 1, 2019
djrtwo
djrtwo reviewed Jul 1, 2019
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a security parameter related to the shuffling algorithm. Just happens to be equal to our validator limit..
@vbuterin suggested removing the assert here

@hwwhww
Copy link
Contributor Author

hwwhww commented Jul 1, 2019

Ahh sorry I thought we set the VALIDATOR_REGISTRY_LIMIT to 2**40 because of the limitation of shuffling function. 😅

@djrtwo djrtwo changed the title Use VALIDATOR_REGISTRY_LIMIT in compute_shuffled_index and Fix ToC remove bounds check in compute_shuffled_index and Fix ToC Jul 1, 2019
@djrtwo djrtwo merged commit d14c150 into dev Jul 1, 2019
@djrtwo djrtwo deleted the use_validator_registry_limit branch July 1, 2019 03:26
@terencechain terencechain mentioned this pull request Jul 1, 2019
Closed
19 tasks
@hwwhww hwwhww mentioned this pull request Jul 5, 2019
Merged
3 tasks
@nisdas nisdas mentioned this pull request Jul 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwwhww @djrtwo