#1244 without "5 slots is a Slot"
#1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hwwhww
added
the
milestone:June 30 freeze 🥶
djrtwo
force-pushed
the
last-minute-cleanups-2
branch
from
ae35bd2 to
476dbdb
Compare
djrtwo
approved these changes
Jul 1, 2019
This was referenced Jul 1, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the contentious part so that #1244 can be merged ASAP.
BLS_WITHDRAWAL_PREFIX_BYTE(should beBLS_WITHDRAWAL_PREFIX)fork_version: bytes=b'\x00' * 4(should befork_version: Version=Version())nin bothint_to_bytesandinteger_squareroot)uint64overintin a few placesBLS_WITHDRAWAL_PREFIXaBytes1JUSTIFICATION_BITS_LENGTHin the constants (as opposed to configurations)