Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bls domain type #1246

Merged
merged 6 commits into from
Jul 1, 2019
Merged

Fix bls domain type #1246

merged 6 commits into from
Jul 1, 2019

Conversation

protolambda
Copy link
Collaborator

cc @JustinDrake

Executed idea to make BLS domain and domain typed, byte4/8 types with their own alias.

@protolambda protolambda added general:presentation Presentation (as opposed to content) milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet labels Jun 30, 2019
@protolambda protolambda requested a review from JustinDrake June 30, 2019 20:21
specs/core/0_beacon-chain.md Outdated Show resolved Hide resolved
specs/core/0_beacon-chain.md Outdated Show resolved Hide resolved
configs/constant_presets/minimal.yaml Show resolved Hide resolved
Copy link
Collaborator

@JustinDrake JustinDrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@prestonvanloon
Copy link
Contributor

Why bytes4/8 instead of uint32/uint64?

@JustinDrake
Copy link
Collaborator

JustinDrake commented Jun 30, 2019

Why bytes4/8 instead of uint32/uint64?

We use uint when we want to do integer addition/multiplication/comparison. Here we're just doing byte concatenation. Also want to use uint64 exclusively for integers.

@djrtwo djrtwo merged commit e5ced03 into dev Jul 1, 2019
@djrtwo djrtwo deleted the fix-bls-domain-type branch July 1, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general:presentation Presentation (as opposed to content) milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants