Renaming of functions in the Misc section
#1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlBeek
added
milestone:June 30 freeze 🥶
JustinDrake
reviewed
Jun 30, 2019
JustinDrake
reviewed
Jun 30, 2019
JustinDrake
reviewed
Jun 30, 2019
JustinDrake
reviewed
Jun 30, 2019
JustinDrake
reviewed
Jun 30, 2019
djrtwo
reviewed
Jun 30, 2019
djrtwo
approved these changes
Jul 1, 2019
This was referenced Jul 1, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per my discussion points in #1237, I think functions that return a value based on other values should have a name that indicates their function. For example I think
compute_shuffle_index&compute_epoch_start_slotare much clearer thanshuffle_index&epoch_start_slot. This implements that.