Executable Validator Guide #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: (112 commits) Minor copyedit Fix typo minor typo fix genesis tests; sign deposit-datas, and lower min validator count for testing add comments to make variations in genesis initialization clear, and about the mix-in in verification Refactor Update 0_beacon-chain.md quick comment on avoiding underflow fix basic test Make timestamp a uint64 Fixes typo Fix genesis balance bug (git add -u) Cleanups and fixes fix finalize on double justification in 123 rule Merge is_genesis_trigger into get_genesis_state Cleanups; think about merging is_genesis_trigger into get_genesis_state Renames: fix typo in justification wording rename/fix roots in justification tests for consistency ...
CarlBeek
added
scope:v-guide
protolambda
reviewed
Jun 30, 2019
Co-Authored-By: Diederik Loerakker <[email protected]>
* dev: delayed_activation_exit_epoch -> compute_activation_exit_epoch remove 'int' types from spec typehints. replace with uint64 'beacon state getters' -> ' beacon state accessors' PR feedback Cleanup Fix bug ready for review A few more cleanups Push draft WIP WIP2 WIP
JustinDrake
reviewed
Jun 30, 2019
JustinDrake
approved these changes
Jun 30, 2019
JustinDrake
reviewed
Jun 30, 2019
3 tasks
This was referenced Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executifing the validator guide in response to @JustinDrake's #1227.
This does not add any tests, it just adds
0_beacon-chain-validator.mdtophase0/spec.pyand fixes some typos and bugs in the V-guide to pass linting.This PR also implements
partial_cleanin the Makefile. This deletes everything except the venvs which is very useful when on limited internet connections.I will be AFK for the next 5 hours, so I will only be able to look at feedback thereafter.