Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #1234

Merged
merged 1 commit into from
Jun 30, 2019
Merged

Fix typo #1234

merged 1 commit into from
Jun 30, 2019

Conversation

JustinDrake
Copy link
Collaborator

@JustinDrake JustinDrake commented Jun 30, 2019 •
edited
Loading

Thanks @NIC619 #1219 (comment)

Curious if linting could have caught this.

CarlBeek
CarlBeek approved these changes Jun 30, 2019
View reviewed changes
Copy link
Contributor

@CarlBeek CarlBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do feel like linting should have caught this. It is passed as an argument to typed functions.

@CarlBeek CarlBeek merged commit 14701aa into dev Jun 30, 2019
@JustinDrake
Copy link
Collaborator Author

@CarlBeek Please open an issue for the linting.

@CarlBeek CarlBeek mentioned this pull request Jun 30, 2019
Closed
@terencechain terencechain mentioned this pull request Jul 1, 2019
Closed
19 tasks
@hwwhww hwwhww mentioned this pull request Jul 5, 2019
Merged
3 tasks
@djrtwo djrtwo deleted the JustinDrake-patch-14 branch September 7, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlBeek CarlBeek CarlBeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustinDrake @CarlBeek