get_attesting_indices set instead of sorted #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
commented
Jun 27, 2019
| @@ -566,7 +569,8 @@ def process_bit_challenge(state: BeaconState, | |||
| chunk_count = get_custody_chunk_count(attestation.data.crosslink) | |||
| assert verify_bitfield(challenge.chunk_bits, chunk_count) | |||
| # Verify the first bit of the hash of the chunk bits does not equal the custody bit | |||
| custody_bit = get_bitfield_bit(attestation.custody_bitfield, attesters.index(challenge.responder_index)) | |||
There was a problem hiding this comment.
Bugfix: The previous accessor here for the responder bit just from the list of attestors would likely correspond to the incorrect bit in the bitfield. Instead it should be the index of the responder within the entire committee.
protolambda
approved these changes
Jun 27, 2019
|
Thanks for putting this together so quickly. |
Co-Authored-By: Preston Van Loon <[email protected]>
JustinDrake
approved these changes
Jun 28, 2019
This was referenced Jul 1, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It came to my attention that
get_attesting_indiceswas still unnecessarily sorting instead of returning aset. The only case that needs sorting is when it is used inconvert_to_indexedrather than in all of the attester accessors used in rewards processing during epoch processing.This actually let me to uncover a small bug in phase 1 that has been resolved.
Thanks @prestonvanloon for bringing this to my attention. I hope this relieves that hotspot you found in your epoch processing.