Clarify get_randao_mix accessor from generate_seed
#1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We avoid a genesis underflow by taking the randao epoch in `generate_seed` to be `+ EPOCHS_PER_HISTORICAL_VECTOR`. This conflicts with the expected epoch bounds noted in `get_randao_mix` and this PR attempts to clarify the situation by leaving a note.
|
IMO both comments (the old one, and the new one) are confusing. Less is more. |
|
I agree less is more :) I can say that we had a validation condition in Trinity based on an earlier instantiation of this comment and it did help catch a bug. So providing the guidance is helpful... I guess it is a matter of style as to where this knowledge lives, if anywhere... Feel free to close the PR if there is consensus this isn't a helpful change |
djrtwo
approved these changes
Jun 29, 2019
djrtwo
changed the title
get_randao_mix accessorget_randao_mix accessor from generate_seed
19 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We avoid a genesis underflow by taking the randao epoch in
generate_seedto be+ EPOCHS_PER_HISTORICAL_VECTOR.This conflicts with the expected epoch bounds noted in
get_randao_mix. This exceptional call toget_randao_mixis noted with a brief comment.