Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardened Eth 1.0 voting strategy #1218

Merged
merged 9 commits into from
Jun 28, 2019
Merged

Hardened Eth 1.0 voting strategy #1218

merged 9 commits into from
Jun 28, 2019

Conversation

JustinDrake
Copy link
Contributor

Addresses #722.

(Todo: find a clean way to tie-break the max by distance.)

@JustinDrake JustinDrake requested review from vbuterin and djrtwo June 26, 2019 11:23
@JustinDrake JustinDrake added the milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet label Jun 26, 2019
Co-Authored-By: Danny Ryan <[email protected]>
Co-Authored-By: Carl Beekhuizen <[email protected]>
@djrtwo djrtwo marked this pull request as ready for review June 28, 2019 03:27
@djrtwo
Copy link
Contributor

djrtwo commented Jun 28, 2019

Is there anything left on this @JustinDrake ?

@JustinDrake
Copy link
Contributor Author

The only thing left is the tie breaker for return max(valid_votes, key=valid_votes.count, default=get_eth1_data(ETH1_FOLLOW_DISTANCE)). Favouring the vote with the smallest distance (as previously specified) makes sense to me.

@JustinDrake
Copy link
Contributor Author

@protolambda Do you feel like adding a test for get_eth1_vote?

@JustinDrake JustinDrake merged commit 2739767 into dev Jun 28, 2019
@protolambda
Copy link
Contributor

@JustinDrake We don't quite have an executable validator spec, but I'm testing the 50% and 51% cases for eth1 voting in in the beacon-spec, in addition to a full block-processing based eth1 voting test.

@JustinDrake JustinDrake mentioned this pull request Jun 28, 2019
@djrtwo djrtwo deleted the eth1votes branch May 20, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants