phase 0 doc standardization b4 spec freeze #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this :) (As a side note, the freeze is only for substantive changes. Cosmetics things such as these are definitely welcome during and after the freeze.) |
|
@djrtwo if i'm understanding correctly, i don't think i touched any var names |
|
@JSON You didn't! That was a comment for @JustinDrake ... |
JustinDrake
approved these changes
Jun 25, 2019
19 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #1039 for documents pertaining to Phase 0, in particular.
Summary:
Dead links, stay-on-the-same-spec links, capitalization for the first word after "Note:" & when referring to a specific phase, abbreviations spelled out when the full version is used more often in the spec and the abbreviated version appears rarely, grammatical commas, standardized syntax for describing where 'Helper functions' on 0_beacon-chain.md are defined, British spelling 'utilised' --> "utilized", etc.