Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpoints in beacon spec #1210

Merged
merged 13 commits into from
Jun 28, 2019
Merged

Checkpoints in beacon spec #1210

merged 13 commits into from
Jun 28, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jun 22, 2019 •
edited
Loading

Ready for review.

Is based on #1198. Let's get that one merge first and then will switch this to merge to dev

@JustinDrake JustinDrake added the milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet label Jun 22, 2019
@JustinDrake
Copy link
Collaborator

I very much like this :)

@djrtwo
Copy link
Contributor Author

djrtwo commented Jun 23, 2019

nice cleanup AttestationData.target_checkpoint -> AttestationData.target

@djrtwo
Copy link
Contributor Author

djrtwo commented Jun 23, 2019

Thoughts on changing state.current_justified_checkpoint to state.current_justified?

changes accessors to state.current_justified.epoch and state.current_justified.root which is nice, but state.current_justified loses a bit of semantic meaning on it's own.

@JustinDrake
Copy link
Collaborator

Thoughts on changing state.current_justified_checkpoint to state.current_justified?

Would be nice to shorten :) Brainstorming:

  • state.currently_justified (reads a bit better as a standalone; also distinguishes semantically from previous_ in previous_epoch_attestations)
  • state.current_justification (reads a bit better as a standalone)

@djrtwo djrtwo changed the title [wip] Checkpoints in beacon spec Checkpoints in beacon spec Jun 25, 2019
@djrtwo djrtwo changed the base branch from dev to fork-choice-epoch June 25, 2019 03:43
@djrtwo djrtwo mentioned this pull request Jun 25, 2019
Merged
@djrtwo djrtwo force-pushed the checkpoints branch 2 times, most recently from 19dd4cd to ac06362 Compare June 25, 2019 17:49
@djrtwo djrtwo force-pushed the fork-choice-epoch branch from 6c1181b to c642896 Compare June 25, 2019 20:48
@djrtwo djrtwo changed the base branch from fork-choice-epoch to dev June 28, 2019 02:48
@djrtwo djrtwo merged commit 1a5de80 into dev Jun 28, 2019
@djrtwo djrtwo deleted the checkpoints branch June 28, 2019 03:26
@terencechain terencechain mentioned this pull request Jul 1, 2019
Closed
19 tasks
@hwwhww hwwhww mentioned this pull request Jul 5, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinDrake JustinDrake JustinDrake approved these changes

Assignees
No one assigned
Labels
milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djrtwo @JustinDrake