Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work-in-progress on SSZ partials #1184

Closed
wants to merge 13 commits into from
Closed

Work-in-progress on SSZ partials #1184

wants to merge 13 commits into from

Conversation

vbuterin
Copy link
Contributor

Now updated to the latest spec.

@JustinDrake JustinDrake added the scope:SSZ Simple Serialize label Jun 17, 2019
@protolambda
Copy link
Collaborator

#1180 Is pretty much ready, tests pass. (fully structured/typed SSZ, less lines 🎉) Just final review + verify SSZ behavior through generator output comparison.
I rebased the partials out of 1180, since this PR is here for those now. The updates to the partials made in 1180 (use of typing, fixes for linting) can be found on the new-partials-updated branch. See commit 58ffa41

After merging the above commit into here, and when 1180 is merged into dev, this PR can complete the adoption of the new SSZ (rebase on dev, drop changes to ssz implementation, just keep partials), and then we can merge this too :)

@protolambda
Copy link
Collaborator

Going to rebase this on new dev branch, then add some things to improve the experience with generalized indices with path-like syntax sugar, as I dislike the array of keys thing.

@protolambda
Copy link
Collaborator

This PR is largely outdated, an during devcon discussions about SSZ standardization and light client work there is a motivation to pick this up again, and move it to a separate repository for various reasons. See final comment on #1261, closing this PR now.

@djrtwo djrtwo deleted the new-partials branch May 20, 2020 23:25
@djrtwo djrtwo restored the new-partials branch May 20, 2020 23:25
@hwwhww hwwhww deleted the new-partials branch February 21, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:SSZ Simple Serialize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants