Fix #1090 #1092
Merged
Fix #1090 #1092
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
approved these changes
May 17, 2019
| @@ -647,7 +647,7 @@ def get_previous_epoch(state: BeaconState) -> Epoch: | |||
| Return the current epoch if it's genesis epoch. | |||
| """ | |||
| current_epoch = get_current_epoch(state) | |||
| return (current_epoch - 1) if current_epoch > GENESIS_EPOCH else current_epoch | |||
| return GENESIS_EPOCH if current_epoch == GENESIS_EPOCH else current_epoch - 1 | |||
There was a problem hiding this comment.
Tiny tiny nitpick: the previous version looks fine to me, and slightly more efficient since we expect in most cases, current_epoch is greater than GENESIS_EPOCH.
There was a problem hiding this comment.
I was trying to make it clear that current_epoch - 1 is not even "considered" unless current_epoch != GENESIS. Not too fussed either way :)
There was a problem hiding this comment.
So in python, the left side is never run if the conditional is False, but I think this makes it slightly clearer to be careful with the subtraction. I'm oky with as is
djrtwo
approved these changes
May 17, 2019
djrtwo
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid signed integers