Proposer slashing tests #1010
Closed
Proposer slashing tests #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannikluhn
force-pushed
the
proposer-slashing-tests
branch
from
3f0d741 to
4ffa3f2
Compare
|
Similarly with test generation presented in #999 (comment here):
|
Merged
|
New tests included in #1052, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for propose slashing as described in #927.
Follows pretty much the structure of the already existing deposit tests.
What's missing are tests with invalid header signatures, and the existing ones aren't properly signed. I think particular for this and in general for all test generators it would be nice to have some additional helper functions that make it easier to create such objects (signed headers, state with validator i exited and j slashed, etc.)