This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
Question about checksumming addresses when seeding a blockie #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also want to know this. Also, why are issues disabled? |
|
After experimenting a bit, I believe that they should be downcased. @alexvandesande Could you add me as a maintainer so I can improve the README? |
|
Ran into this issue today when trying to implement Blockies in my dApp so that it matches the user's desired wallet connector. (MetaMask, Fortmatic, etc..) I actually filed an issue w/ MetaMask inquiring why the downcasing is necessary, since not all wallets format the seed string: MetaMask/metamask-extension#9973 @briansoule can you explain your reasoning? |
|
If I recall correctly, I experimented with different formats until it produced the expected behavior. @DannyDelott Can you confirm? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should addresses be checksummed or downcased when creating a blockie?