Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing of JSON metadata. #342

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Conversation

mcdee
Copy link
Contributor

@mcdee mcdee commented Jul 28, 2023

Casing of the JSON metadata for the v3 block API was in kebab case (as per headers) but should be in camel case as per all other JSON.

Casing of the JSON metadata for the v3 block API was in kebab case (as
per headers) but should be in camel case as per all other JSON.
@james-prysm
Copy link
Contributor

looks good ! thanks

@rolfyone
Copy link
Collaborator

this is only replacing - with _ but the comment is casing... makes sense but i'll hold off merging until you confirm...

@mcdee
Copy link
Contributor Author

mcdee commented Jul 29, 2023

Yeah it's just the change from - to _.

@rolfyone rolfyone merged commit ea56687 into ethereum:master Jul 29, 2023
2 checks passed
@Falehfale Falehfale mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants