-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sync_committee_rewards
#262
Add sync_committee_rewards
#262
Conversation
@michaelsproul how do you plan to fulfill this API? AFAIK we don't have that information available after block processing since the rewards are "merged" into the balances array |
@dapplion I'm intending to replay blocks. For sync aggregates it's just a matter of loading the pre-state, and calculating the rewards based on the bits set in the sync aggregate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Almost ready to go I think
sync_committee_rewards
sync_committee_rewards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm happy to merge.
Just renamed types/sync_committee_rewards.yaml to rewards.yaml. It will be merged with types/rewards.yaml in the other PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think post will be better once you get into it, so thanks for persisting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reference: #260 (review)
/eth/v1/beacon/rewards/sync_committee/{block_id}