Cleanup old endpoints that have been deprecated #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- v1/debug/states has been deprecated for a long time now, as has the v1/blocks endpoint. - v1/debug/heads seems to be a new deprecation so leaving that in the spec. I'm not sure why v2 exists, it looks like the execution_optimistic should have just been optional so that it was non breaking, but that horse hs bolted.
mpetrunic
approved these changes
May 23, 2022
Comment on lines
-81
to
-82
| /eth/v1/beacon/blocks: | ||
| $ref: "./apis/beacon/blocks/blocks.yaml" |
There was a problem hiding this comment.
I don't think this should have been deleted. This API endpoint isn't deprecated and is the only way for validator clients to publish their non-blinded blocks to the beacon node
There was a problem hiding this comment.
hrm i may have deleted the wrong thing? will check now...
There was a problem hiding this comment.
you're correct, raising a pr to put back
rolfyone
added a commit
to rolfyone/beacon-APIs
that referenced
this pull request
Sep 13, 2022
Mistakenly removed in ethereum#218, this PR puts back the /eth/v1/beacon/blocks POST.
mpetrunic
pushed a commit
that referenced
this pull request
Sep 13, 2022
* Added POST /eth/v1/beacon/blocks back in place Mistakenly removed in #218, this PR puts back the /eth/v1/beacon/blocks POST. * Update beacon-node-oapi.yaml Co-authored-by: Michael Sproul <[email protected]> Co-authored-by: Michael Sproul <[email protected]>
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Sep 28, 2022
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1/debug/states has been deprecated for a long time now, as has the v1/blocks endpoint.
v1/debug/heads seems to be a new deprecation so leaving that in the spec. I'm not sure why v2 exists, it looks like the execution_optimistic should have just been optional so that it was non breaking, but that horse hs bolted.