Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

aleth-precompiles library #5855

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

aleth-precompiles library #5855

wants to merge 10 commits into from

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Nov 28, 2019

Fixes #5788

This replaces the precompiles infrastructure with the new EVMC module library.

Information about which revision activates each precompile for now is still in ChainParams class.

Option to build as a shared library is not added yet.

@codecov-io
Copy link

codecov-io commented Dec 23, 2019

Codecov Report

Merging #5855 into master will increase coverage by 0.02%.
The diff coverage is 86.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5855      +/-   ##
==========================================
+ Coverage   63.94%   63.96%   +0.02%     
==========================================
  Files         365      364       -1     
  Lines       31098    31103       +5     
  Branches     3441     3441              
==========================================
+ Hits        19885    19895      +10     
+ Misses       9980     9974       -6     
- Partials     1233     1234       +1

@gumb0 gumb0 removed the in progress label Dec 24, 2019
@gumb0 gumb0 marked this pull request as ready for review December 24, 2019 19:33
@gumb0 gumb0 requested a review from chfast December 24, 2019 20:26
extern "C" {
#endif

EVMC_EXPORT struct evmc_vm* evmc_create_aleth_precompiles_vm() EVMC_NOEXCEPT;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the library name is aleth-precompiles this should be named evmc_create_aleth_precompiles for EVMC loader to work.

@axic
Copy link
Member

axic commented May 6, 2020

What was the blocker on this? Lack of time / lack of usefulness?

@gumb0
Copy link
Member Author

gumb0 commented May 6, 2020

What was the blocker on this? Lack of time / lack of usefulness?

Rather lack of usefulness.

But this PR is ready from my side except evmc_create_aleth_precompiles naming problem mentioned above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package Precompiles implementations into EVMC module
4 participants