Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC: ERC-721 Name Registry Extension #292

Merged
merged 29 commits into from
Apr 16, 2024
Merged

Add ERC: ERC-721 Name Registry Extension #292

merged 29 commits into from
Apr 16, 2024

Conversation

chenly
Copy link
Contributor

@chenly chenly commented Mar 1, 2024

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Mar 1, 2024 •
edited
Loading

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Add ERC: ERC-721 Name Registry Extension Add ERC: ERC-721 Name Registry Extension Mar 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

The commit 6eda2d3 (as a parent of ef4ee18) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Mar 1, 2024
abcoathup
abcoathup reviewed Mar 1, 2024
View reviewed changes
ERCS/erc-9999.md Outdated Show resolved Hide resolved
abcoathup
abcoathup reviewed Mar 1, 2024
View reviewed changes
ERCS/erc-9999.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-ci label Mar 2, 2024
@chenly chenly mentioned this pull request Mar 5, 2024
Closed
14 tasks
SamWilsn
SamWilsn reviewed Mar 5, 2024
View reviewed changes
ERCS/erc-7644.md Outdated Show resolved Hide resolved
ERCS/erc-7644.md Outdated Show resolved Hide resolved
ERCS/erc-7644.md Outdated Show resolved Hide resolved
ERCS/erc-7644.md Outdated Show resolved Hide resolved
@chenly chenly requested a review from SamWilsn March 7, 2024 16:46
@chenly chenly mentioned this pull request Mar 17, 2024
Closed
13 tasks
@poojaranjan poojaranjan mentioned this pull request Mar 19, 2024
Closed
18 tasks
@poojaranjan poojaranjan mentioned this pull request Apr 3, 2024
Closed
27 tasks
SamWilsn
SamWilsn approved these changes Apr 16, 2024
View reviewed changes
ERCS/erc-7644.md Show resolved Hide resolved
@eip-review-bot eip-review-bot enabled auto-merge (squash) April 16, 2024 14:19
eip-review-bot
eip-review-bot approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 5880029 into ethereum:master Apr 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@eip-review-bot eip-review-bot eip-review-bot approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

Assignees
No one assigned
Labels
c-new e-consensus e-review s-draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenly @eip-review-bot @abcoathup @SamWilsn @bizliaoyuan