Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC-1363: Add missing return statement #213

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Update ERC-1363: Add missing return statement #213

merged 1 commit into from
Mar 5, 2024

Conversation

vittominacori
Copy link
Contributor

Just adding an explicit return value docs as it was missing for no reason.

The approveAndCall methods are aligned with the transferAndCall and transferFromAndCall methods.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jan 22, 2024 •
edited
Loading

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Add missing return statement Update ERC-1363: Add missing return statement Jan 22, 2024
@github-actions GitHub Actions
Copy link

The commit 9b2f57e (as a parent of 80f84cf) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Jan 22, 2024
@vittominacori vittominacori mentioned this pull request Jan 25, 2024
Closed
3 tasks
@poojaranjan poojaranjan mentioned this pull request Feb 14, 2024
Closed
5 tasks
@vittominacori
Copy link
Contributor Author

@SamWilsn @g11tech still waiting to merge

@vittominacori
Copy link
Contributor Author

@poojaranjan @SamWilsn @g11tech really cannot understand why is this PR still pending if approved.

@poojaranjan poojaranjan mentioned this pull request Mar 5, 2024
Closed
14 tasks
@SamWilsn
Copy link
Collaborator

SamWilsn commented Mar 5, 2024

The bot's comment above includes the merge requirements:

Requires 1 more reviewers from [...]

@eip-review-bot eip-review-bot enabled auto-merge (squash) March 5, 2024 15:10
eip-review-bot
eip-review-bot approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@SamWilsn SamWilsn disabled auto-merge March 5, 2024 15:13
@SamWilsn SamWilsn merged commit 98037d7 into ethereum:master Mar 5, 2024
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eip-review-bot eip-review-bot eip-review-bot approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

@lightclient lightclient lightclient approved these changes

Assignees
No one assigned
Labels
c-update e-consensus s-final t-erc w-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vittominacori @eip-review-bot @SamWilsn @lightclient