Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC-1046: Fix typos #154

Closed
wants to merge 19 commits into from
Closed

Update ERC-1046: Fix typos #154

wants to merge 19 commits into from

Conversation

nnsW3
Copy link
Contributor

@nnsW3 nnsW3 commented Dec 10, 2023

Hello,
I fixed several minor typos found in your documentation.
Hope it helps.
Br, Elias.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Dec 10, 2023 •
edited
Loading

File ERCS/erc-1046.md

Requires 1 more reviewers from @JohnZettler, @mateosu, @Pandapip1, @shrugs, @tomasienrbc
Requires 1 more reviewers from @axic, @gcolvin, @lightclient

File ERCS/erc-1081.md

Requires 1 more reviewers from @3esmit

File ERCS/erc-1129.md

Requires 1 more reviewers from @ThunderDeliverer

File ERCS/erc-1185.md

Requires 1 more reviewers from @mcdee

File ERCS/erc-1207.md

Requires 1 more reviewers from @Wangbicong, @wxygeek

File ERCS/erc-1123.md

Requires 1 more reviewers from @axic, @gcolvin, @lightclient

@eip-review-bot eip-review-bot changed the title Fix typos Update ERC-1046: Fix typos Dec 10, 2023
@github-actions github-actions bot added the w-ci label Dec 10, 2023
@poojaranjan poojaranjan mentioned this pull request Dec 12, 2023
Closed
11 tasks
SamWilsn
SamWilsn reviewed Dec 13, 2023
View reviewed changes
ERCS/erc-1261.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-ci label Dec 13, 2023
@github-actions github-actions bot added the w-ci label Dec 13, 2023
pipermerriam
pipermerriam approved these changes Dec 20, 2023
View reviewed changes
ERCS/erc-1123.md
@@ -1593,7 +1593,7 @@ A URI in the format `blockchain://<chain_id>/block/<block_hash>`
- `block_hash` is the unprefixed hexadecimal representation of the
hash of a block on the chain.

A chain is considered to match a chain definition if the the genesis
A chain is considered to match a chain definition if the genesis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

chaitanyapotti
chaitanyapotti approved these changes Jan 24, 2024
View reviewed changes
Copy link

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions GitHub Actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions GitHub Actions
Copy link

The commit b2ee8af (as a parent of ef79e5a) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-stale label Feb 25, 2024
@poojaranjan poojaranjan mentioned this pull request Mar 5, 2024
Closed
10 tasks
@github-actions GitHub Actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@SamWilsn
Copy link
Collaborator

I'm going to close this because it'll be impossible to get approval from all the authors at the same time. Please re-open separate pull requests for each proposal.

@SamWilsn SamWilsn closed this Mar 13, 2024
@bumblefudge
Copy link

bumblefudge commented Mar 13, 2024 •
edited
Loading

maybe there's some easy way to move each commit to a new PR in github dot com?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn approved these changes

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

@pipermerriam pipermerriam pipermerriam approved these changes

@juli juli juli approved these changes

@eip-review-bot eip-review-bot Awaiting requested review from eip-review-bot eip-review-bot is a code owner

Assignees
No one assigned
Labels
c-update e-consensus s-final s-review s-stagnant s-withdrawn t-erc w-ci w-stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nnsW3 @eip-review-bot @SamWilsn @bumblefudge @juli @pipermerriam @chaitanyapotti