Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Separate Metadata Section for EOF #9100

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

kuzdogan
Copy link
Member

@kuzdogan kuzdogan commented Dec 6, 2024

No description provided.

@kuzdogan kuzdogan requested a review from eth-bot as a code owner December 6, 2024 14:09
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Dec 6, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 6, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Dec 6, 2024
@eth-bot eth-bot changed the title Add EIP draft: Separate Metadata Section for EOF Add EIP: Separate Metadata Section for EOF Dec 6, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Dec 6, 2024
EIPS/eip-eof-metadata.md Outdated Show resolved Hide resolved
title: Separate Metadata Section for EOF
description: Introduce a new separate metadata section to the EOF
author: Kaan Uzdogan (@kuzdogan), Marco Castignoli (@marcocastignoli), Manuel Wedler (@manuelwedler)
discussions-to: <URL>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a discussions topic in Eth Magicians using the template: https://ethereum-magicians.org/c/eips/5

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Co-authored-by: Andrew B Coathup <[email protected]>
@kuzdogan kuzdogan changed the title Add EIP: Separate Metadata Section for EOF Add EIP-7834: Separate Metadata Section for EOF Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

The commit fe8cdb5 (as a parent of bbb3183) contains errors.
Please inspect the Run Summary for details.

@eth-bot eth-bot changed the title Add EIP-7834: Separate Metadata Section for EOF Add EIP: Separate Metadata Section for EOF Dec 11, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Dec 11, 2024
EIPS/eip-7834.md Outdated

## Motivation

It is desirable to include metadata in contract's bytecode for various reasons. For instance, both the Solidity and Vyper compilers by default include the language and compiler version used to compile. Solidity additionally includes the IPFS or the Swarm hash of the Solidity contract metadata.json file, and the experimental Solidity flag. The current (pre-EOF) practice is to append this CBOR encoded metadata section in the contract's runtime bytecode, followed by the 2 bytes length of the CBOR encoded bytes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, in Vyper 0.4.1 (to be released), the integrity hash (using sha256 under to the hood) is now put into the initcode (not runtime code) (vyperlang/vyper#4234) to preserve bytecode space of the runtime code. That's also a smart way to deal with it ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, thanks for the info

@eth-bot eth-bot enabled auto-merge (squash) December 17, 2024 09:20
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 821ffeb into ethereum:master Dec 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants