-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Separate Metadata Section for EOF #9100
Conversation
✅ All reviewers have approved. |
EIPS/eip-eof-metadata.md
Outdated
title: Separate Metadata Section for EOF | ||
description: Introduce a new separate metadata section to the EOF | ||
author: Kaan Uzdogan (@kuzdogan), Marco Castignoli (@marcocastignoli), Manuel Wedler (@manuelwedler) | ||
discussions-to: <URL> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a discussions topic in Eth Magicians using the template: https://ethereum-magicians.org/c/eips/5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
Co-authored-by: Andrew B Coathup <[email protected]>
Co-authored-by: Manuel Wedler <[email protected]>
The commit fe8cdb5 (as a parent of bbb3183) contains errors. |
EIPS/eip-7834.md
Outdated
|
||
## Motivation | ||
|
||
It is desirable to include metadata in contract's bytecode for various reasons. For instance, both the Solidity and Vyper compilers by default include the language and compiler version used to compile. Solidity additionally includes the IPFS or the Swarm hash of the Solidity contract metadata.json file, and the experimental Solidity flag. The current (pre-EOF) practice is to append this CBOR encoded metadata section in the contract's runtime bytecode, followed by the 2 bytes length of the CBOR encoded bytes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, in Vyper 0.4.1
(to be released), the integrity hash (using sha256
under to the hood) is now put into the initcode (not runtime code) (vyperlang/vyper#4234) to preserve bytecode space of the runtime code. That's also a smart way to deal with it ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added, thanks for the info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
No description provided.