Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-6596: Move to Review #7861

Closed
wants to merge 1 commit into from
Closed

Update EIP-6596: Move to Review #7861

wants to merge 1 commit into from

Conversation

dhl
Copy link
Contributor

@dhl dhl commented Oct 17, 2023

No description provided.

@dhl dhl requested a review from eth-bot as a code owner October 17, 2023 02:49
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Oct 17, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 17, 2023 •
edited
Loading

File EIPS/eip-6596.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot changed the title Update EIP-6596: Spec update Update EIP-6596: Move to Review Oct 17, 2023
@eth-bot eth-bot added the e-review Waiting on editor to review label Oct 17, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 17, 2023
@github-actions
Copy link

The commit 07e7232 (as a parent of 881d627) contains errors.
Please inspect the Run Summary for details.

macmac0726171992
macmac0726171992 approved these changes Oct 17, 2023
View reviewed changes
Copy link

@macmac0726171992 macmac0726171992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

macmac0726171992
macmac0726171992 approved these changes Oct 17, 2023
View reviewed changes
Copy link

@macmac0726171992 macmac0726171992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Oct 17, 2023
@dhl dhl force-pushed the update_erc-6596_r1 branch 5 times, most recently from 01d62ae to dd2c824 Compare October 17, 2023 09:11
@dhl dhl mentioned this pull request Oct 24, 2023
Closed
26 tasks
@SamWilsn
Copy link
Contributor

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

@SamWilsn SamWilsn closed this Oct 26, 2023
@dhl
Copy link
Contributor Author

dhl commented Oct 27, 2023

Thank you @SamWilsn for looking into our PR. We'll resubmit to the ERCs repo.

@dhl dhl mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macmac0726171992 macmac0726171992 macmac0726171992 approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-review This EIP is in Review t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhl @eth-bot @SamWilsn @macmac0726171992