Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-1: locally disable MD046 footnote demo #6487

Closed
wants to merge 1 commit into from
Closed

Update EIP-1: locally disable MD046 footnote demo #6487

wants to merge 1 commit into from
+4 −0

Conversation

xinbenlv
Copy link
Contributor

@xinbenlv xinbenlv commented Feb 9, 2023 •
edited
Loading

A follow up for

We should turn off that error. I think it's the only way to get a code block to appear inside the footnote list.

Originally posted by @SamWilsn in #6477 (comment)

@github-actions github-actions bot added c-update Modifies an existing proposal t-process labels Feb 9, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 9, 2023 •
edited
Loading

File EIPS/eip-1.md

Requires 1 more reviewers from @SamWilsn, @axic, @gcolvin, @lightclient

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

The commit 2f3c6bf (as a parent of 9f7c06d) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 9, 2023
Pandapip1
Pandapip1 approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lightclient
Copy link
Member

How do we fix the linter here?

@SamWilsn
Copy link
Contributor

SamWilsn commented Jun 1, 2023

This looks like it's been fixed in EIP-1? Please reopen if not.

@SamWilsn SamWilsn closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

@SamWilsn SamWilsn Awaiting requested review from SamWilsn

Assignees
No one assigned
Labels
c-update Modifies an existing proposal t-process w-ci Waiting on CI to pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xinbenlv @eth-bot @lightclient @SamWilsn @Pandapip1