Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-5507: Move to review #6186

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Update EIP-5507: Move to review #6186

merged 1 commit into from
Jan 10, 2023

Conversation

Pandapip1
Copy link
Member

No description provided.

@Pandapip1 Pandapip1 requested a review from eth-bot as a code owner December 20, 2022 20:34
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Dec 20, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 20, 2022 •
edited
Loading

A critical exception has occurred:
Message: pr 6186 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

SamWilsn
SamWilsn reviewed Dec 25, 2022
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should compute the interface ids.

@Pandapip1 Pandapip1 marked this pull request as draft December 25, 2022 20:26
@Pandapip1 Pandapip1 marked this pull request as ready for review December 26, 2022 16:16
@Pandapip1 Pandapip1 requested a review from SamWilsn December 26, 2022 16:16
@poojaranjan poojaranjan mentioned this pull request Dec 27, 2022
Closed
12 tasks
SamWilsn
SamWilsn reviewed Dec 27, 2022
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the interface id is still 0xTODO?

@Pandapip1
Copy link
Member Author

Pandapip1 commented Dec 27, 2022 •
edited
Loading

Looks like the interface id is still 0xTODO?

The branch is out of date. It's been fixed on master: https://eips.ethereum.org/EIPS/eip-5507

@poojaranjan poojaranjan mentioned this pull request Jan 9, 2023
Closed
25 tasks
@eth-bot eth-bot enabled auto-merge (squash) January 10, 2023 15:15
@eth-bot eth-bot merged commit d6f47fc into master Jan 10, 2023
@eth-bot eth-bot deleted the eip-5507-review branch January 10, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

Assignees
No one assigned
Labels
c-status Changes a proposal's status s-review This EIP is in Review t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pandapip1 @eth-bot @SamWilsn