-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP-6051: Private Key Encapsulation #6051
Conversation
…ess of the private key
A critical exception has occurred: |
Co-authored-by: xinbenlv <[email protected]>
Hi @xinbenlv I had pushed some more commits to address all issues except the |
Co-authored-by: xinbenlv <[email protected]>
Co-authored-by: xinbenlv <[email protected]>
Co-authored-by: xinbenlv <[email protected]>
Co-authored-by: xinbenlv <[email protected]>
Co-authored-by: xinbenlv <[email protected]>
Co-authored-by: xinbenlv <[email protected]>
Hi @xinbenlv thank you again for the very careful and very detailed reviews. I can see why EIP editors are so overwhelmed. I really appreciate what you had done here. I think I have fixed all issues. I also ran another round with grammarly.com and fixed almost all issues it suggests (with very few I did not agree with it). Please review again when you do find time. |
From a technical perspective, I personally still think, if the EIP is defining a way to encapsulate and unwrap private key via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to merge as a draft now. Defer to @Pandapip1 @SamWilsn to follow up the merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestions accepted
Co-authored-by: Pandapip1 <[email protected]>
Co-authored-by: Pandapip1 <[email protected]>
Co-authored-by: Pandapip1 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for a draft
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: