Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-1: add devp2p repo as accepted external resource #6034

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Update EIP-1: add devp2p repo as accepted external resource #6034

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91f3b23
eip-1: add devp2p repo as accepted external resource
lightclient Nov 22, 2022
4a54c6c
Fix minor grammatical error
Pandapip1 Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions EIPS/eip-1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,24 @@ Permitted Consensus Layer Specifications URLs must anchor to a specific commit,
^https://github.com/ethereum/consensus-specs/blob/[0-9a-f]{40}/.*$
```

### Networking Specifications

Links to the Ethereum Networking Specifications may be included using normal markdown syntax, such as:
Copy link
Member

@Pandapip1 Pandapip1 Nov 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Links to the Ethereum Networking Specifications may be included using normal markdown syntax, such as:
Links to specific commits and files in specific commits of the Ethereum Networking Specifications GitHub repository may be included using the normal markdown link syntax, such as:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text should be consistent between consensus and networking specs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I suggest that the text be changed for both, then?


```markdown
[Ethereum Wire Protocol](https://github.com/ethereum/devp2p/blob/40ab248bf7e017e83cc9812a4e048446709623e8/caps/eth.md)
```

Which renders as:

[Ethereum Wire Protocol](https://github.com/ethereum/devp2p/blob/40ab248bf7e017e83cc9812a4e048446709623e8/caps/eth.md)

Permitted Networking Specifications URLs must anchor to a specific commit, and so must match this regular expression:

```regex
^https://github.com/ethereum/devp2p/blob/[0-9a-f]{40}/.*$
```

### Digital Object Identifier System

Links qualified with a Digital Object Identifier (DOI) may be included using the following syntax:
Expand Down