Update EIP-2481: Move to final #6015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-status
|
A critical exception has occurred: |
cburgdorf
previously approved these changes
Nov 21, 2022
Pandapip1
previously requested changes
Dec 12, 2022
SamWilsn
requested changes
Dec 13, 2022
There was a problem hiding this comment.
Couple changes you need to make that were too far from a changed line for me to comment on:
- Links to devp2p are allowed, but have to be qualified by a commit hash. See the one suggestion I was able to make for the format. (needs Pickup latest eipw version #6091)
- "Test cases" -> "Test Cases"
Co-authored-by: Sam Wilson <[email protected]>
SamWilsn
approved these changes
Dec 16, 2022
|
@cburgdorf would you mind reapproving if everything is in order? |
cburgdorf
approved these changes
Dec 19, 2022
eth-bot
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP has been in last call for ~6 months. Eth/66 has long been implemented by all clients, so this should be final already