EIP4844: Update crypto API (simplify precompile / sync with consensus-specs) #6002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
All tests passed; auto-merging...(pass) eip-4844.md
|
kevaundray
previously approved these changes
Nov 19, 2022
protolambda
previously approved these changes
Nov 22, 2022
See ethereum/consensus-specs#3097 for the changes to the verify_kzg_proof API
asn-d6
force-pushed
the
eip4844-precompile-crypto
branch
from
e0277e2
to
2b84aee
Compare
eth-bot
approved these changes
Nov 22, 2022
protolambda
approved these changes
Nov 22, 2022
|
@MicahZoltu George (asn-d6) disabled auto-merge to get my review after changes in, but now the PR is stuck. Can you help us merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things (split into corresponding commits):
verify_kzg_proof()from EIP4844: Refactorverify_kzg_proof()to receive bytes (used in precompile) consensus-specs#3097 . This way the client developers don't need to understand what field elements are, and can just pass bytes to the KZG library.validate_blob_transaction_wrapper()to the latest high-level crypto API of the consensus specs introduced in EIP4844: Update cryptography API and Fiat-Shamir logic consensus-specs#3038