Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README: Update automatic check descriptions #5926

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Update README: Update automatic check descriptions #5926

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d37562
Update README: Update automatic check descriptions
Pandapip1 Nov 13, 2022
e7fe91a
Apply suggestions from code review
Pandapip1 Nov 13, 2022
4fdd087
reword
lightclient Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,20 @@ Please consider anything which is not published on <https://eips.ethereum.org/>

And please consider anything published at <https://eips.ethereum.org/> with a status of "draft" as an incomplete draft.

## Automerger
## Validation and Automerging

This repository contains an "auto-merge" feature to ease the workload for EIP editors. Pull requests to any EIP will be auto-merged if the EIP's authors approve the PR on GitHub. This is handled by [EIP-Bot](https://github.com/ethereum/EIP-Bot).
All pull requests in this repository must pass automated checks before they can be automatically merged:

## Validation
- [EIP-Bot](https://github.com/ethereum/EIP-Bot/) determines when PRs can be automatically merged [^1]
- EIP-1 rules are enforced using [EIP Walidator](https://github.com/ethereum/eipw)[^2][^3]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- EIP-1 rules are enforced using [EIP Walidator](https://github.com/ethereum/eipw)[^2][^3]
- EIP-1 rules are enforced using [EIP Walidator](https://github.com/ethereum/eipw)[^2]

Pandapip1 marked this conversation as resolved.
Show resolved Hide resolved
- HTML formatting and broken links are enforced using [HTMLProofer](https://github.com/gjtorikian/html-proofer)[^2]
- Spelling is enforced with [CodeSpell](https://github.com/codespell-project/codespell)[^2]
- False positives sometimes occur. When this happens, please immediately submit a PR editing [.codespell-whitelist](https://github.com/ethereum/EIPs/blob/master/config/.codespell-whitelist).
Pandapip1 marked this conversation as resolved.
Show resolved Hide resolved
- Markdown best practices are checked using [markdownlint](https://github.com/DavidAnson/markdownlint)[^2]

Pull requests in this repository must pass automated validation checks:

- HTML formatting, broken links, and EIP front matter/formatting are [checked](https://github.com/ethereum/EIPs/blob/master/.github/workflows/ci.yml) using [html-proofer](https://rubygems.org/gems/html-proofer) and [`eipw`](https://github.com/ethereum/eipw).
- Required pull request reviews are [enforced](https://github.com/ethereum/EIPs/blob/master/.github/workflows/auto-review-bot.yml) using [EIP-Bot](https://github.com/ethereum/EIP-Bot/).
[^1]: https://github.com/ethereum/EIPs/blob/master/.github/workflows/auto-review-bot.yml
[^2]: https://github.com/ethereum/EIPs/blob/master/.github/workflows/ci.yml
[^3]: Not a typo 😈
Pandapip1 marked this conversation as resolved.
Show resolved Hide resolved

It is possible to run the EIP validator locally:

Expand Down