Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-721: delete broken openzeppelin links #5903

Closed

Conversation

konojunya
Copy link

In the NFT Implementation and Other Projects column, the 17th link is to openzeppelin, which is already an invalid link and also a link to SafeERC20. openzeppelin has an ERC721 implementation.
The link should be to ERC721.sol

ref: https://eips.ethereum.org/EIPS/eip-721#references

@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-erc labels Nov 9, 2022
@konojunya konojunya force-pushed the docs/fix-erc721-openzeppelin-link branch from 39c4801 to ed500a5 Compare November 9, 2022 15:06
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 9, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-721.md

classification
updateEIP

Pandapip1
Pandapip1 previously approved these changes Nov 9, 2022
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0. I would prefer the links to be removed altogether, but I'd rather the link be fixed than a broken link stay.

fulldecent
fulldecent previously approved these changes Nov 9, 2022
@eth-bot eth-bot enabled auto-merge (squash) November 9, 2022 16:00
eth-bot
eth-bot previously approved these changes Nov 9, 2022
@@ -440,7 +440,7 @@ XXXXERC721, by William Entriken -- a scalable example implementation
1. Curio Cards. https://mycuriocards.com
1. Rare Pepe. https://rarepepewallet.com
1. Auctionhouse Asset Interface. https://github.com/dob/auctionhouse/blob/master/contracts/Asset.sol
1. OpenZeppelin SafeERC20.sol Implementation. https://github.com/OpenZeppelin/zeppelin-solidity/blob/master/contracts/token/ERC20/SafeERC20.sol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!
This is a historical doc, to fix it

  1. Editors are working on a link policy per EIP-5757 (Add EIP-5757: Propose process for allowing external links #5757 ), let's wait for that to be finalized
  2. Links are generally suggested to use permlink to reduce chance of such broken links in the future

But still, thank you for your contribution! Greatly appreciated

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xinbenlv Yes. Exactly. This EIP is referenced by many people and we should wait for the Editors reply as it is a change to a part of that document.
I too recommend using permlink, but since the source of the change points to the default branch, I made the change using the same policy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links are generally suggested to use permlink to reduce chance of such broken links in the future

So, in this case, would the better fix be to replace the broken link with a permlink to the last SafeERC20, rather than a link to ERC721?

And, given these links are no normative, and this one is not discussed in the proposal, I'd be happy to see it removed.

@konojunya
Copy link
Author

@SamWilsn @axic @gcolvin @lightclient

How are you?
Let us know what you think!

@SamWilsn
Copy link
Contributor

SamWilsn commented Nov 15, 2022

I think my preference for this would be to remove the links entirely. I don't want to establish a precedent of updating broken links in old EIPs.

Should probably be discussed on EIPIP...

@konojunya
Copy link
Author

konojunya commented Nov 15, 2022

@SamWilsn In my opinion, I leave the update or deletion to the outcome of the discussion, but the current situation with the wrong link should be changed.

Even if it were removed, the openzeppelin implementation of EIP-721 would have little impact because it is widely known, but the EIP-721 page does not have a reference implementation like EIP-4907, so newcomers could lose the link to a valuable source of information.

@Pandapip1
Copy link
Member

I think my preference for this would be to remove the links entirely. I don't want to establish a precedent of updating broken links in old EIPs.

This is my preference too. However, I would like to establish a precedent for updating broken links in old EIPs. I would just like there to also be a precedent of deleting those old links too.

@konojunya
Copy link
Author

I understand your basic policy. I will add a commit in the form of a deletion rather than an update to the link.

auto-merge was automatically disabled November 19, 2022 22:18

Head branch was pushed to by a user without write access

@konojunya konojunya changed the title Update EIP-721: broken and mislinked openzeppelin links Update EIP-721: delete broken openzeppelin links Nov 19, 2022
@fulldecent
Copy link
Contributor

Please close this PR in favor of #6012


The link to ERC-20 implemented by OpenZeppelin is correct and intentional.

This citation is an important part of the justification of how ERC-721 (and frankly, all) token standards currently work. The text explains the risks of the old ERC-20 behavior and advocates that when transactions fail they should throw, something many now take for granted.

@Pandapip1 Pandapip1 closed this Nov 20, 2022
@konojunya konojunya deleted the docs/fix-erc721-openzeppelin-link branch July 30, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-final This EIP is Final t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants