-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address some copy editing issues #5890
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems EIPW is complaining... Let me see if I could quickly fix it
EIPS/eip-5732.md
Outdated
@@ -10,44 +10,37 @@ type: Standards Track | |||
category: ERC | |||
created: 2022-09-29 | |||
requires: 165 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fulldecent for helping editing. I also fixes some copy editing pieces. and also addressed the question you brought up in the ethereum-magicians.org
@fulldecent thanks for the PR, could you go ahead apply the suggested change and you shall be good to merge this PR. Or I am also happy to carry it out if you are bounded by bandwidth |
Hi @fulldecent thank you for the help. Since you didn't respond, I created a PR using your commits, incorporating my suggested edits. and becomes PR 5910 and PR 5909.
By now I believe I've addressed all your feedbacks. Thank you very much! For you and everyone else, please let me know if there are any other suggestions / feedback for this EIP before we finalize it |
With the above incorporations, feel free to close this PR. |
Co-authored-by: xinbenlv <[email protected]>
Head branch was pushed to by a user without write access
@xinbenlv Thank you, all updated |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: