Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate @xinbenlv review #5599

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Incorporate @xinbenlv review #5599

merged 1 commit into from
Sep 5, 2022

Conversation

gcolvin
Copy link
Contributor

@gcolvin gcolvin commented Sep 5, 2022

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Sep 5, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 5, 2022

All tests passed; auto-merging...

(pass) eip-2315.md

classification
updateEIP
  • passed!

@eth-bot eth-bot enabled auto-merge (squash) September 5, 2022 22:31
@eth-bot eth-bot merged commit e399b8d into ethereum:master Sep 5, 2022
@gcolvin gcolvin deleted the patch-3 branch September 5, 2022 22:38
Copy link
Contributor

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcolvin gcolvin restored the patch-3 branch September 9, 2022 19:35
@gcolvin gcolvin deleted the patch-3 branch September 21, 2022 23:39
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants