-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP-5553: Intellectual Property Representation with Royalties #5553
Conversation
All tests passed; auto-merging...(pass) eip-5553.md
|
* Rationale wording * Link to EIP-5218 * Moved abstract functions to spec descriptions
Folks, thanks for your time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the grammar in the specification section.
OK I looked at all the grammar issues I could find and fixed them. Not sure which ones you meant. If you point out something more specific I'm happy to fix it. |
SongRegistration -> MusicalIP royaltyInterestTokens -> royaltyRightsTokens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run this through Grammarly. It'll catch things like L41 not starting with a capital letter and a duplicated word on L249.
Anything else keeping this from being merged? |
Grammar mistakes. I'll run it through Grammarly myself I guess. |
Ok. Will run it through grammarly next time.Sorry about that. Missed your previous comment.
|
…hereum#5553) * ERC821 * wording * discussions link * fixes for EIP checks * fix bot reeview changes * fix validator checks * typos * typos * Assign EIP-5553 * Update eip-5553.md wording * Update eip-5553.md * Fix codespell errors * * Added security considerations * Rationale wording * Link to EIP-5218 * Moved abstract functions to spec descriptions * Reference implementation section * shorten abstract * fix link * link fix * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * Fix wording * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * wording * move rationale up * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5553.md Co-authored-by: Pandapip1 <[email protected]> * wording * Update eip-5553.md * Update eip-5553.md * Update eip-5553.md * Wording. * Grammar fix in specification * Code renames SongRegistration -> MusicalIP royaltyInterestTokens -> royaltyRightsTokens * Fix grammar and spelling Co-authored-by: Pandapip1 <[email protected]>
A standardized way to represent intellectual works on chain, along with a refined royalty representation mechanism and associated metadata. This standard is not associated with a specific type of work and could represent many types of works such as musical works, videos, books, images and more.
The standard is kept very generic on purpose to allow the industry to evolve new ecosystems that can all rely on the same basic standard at their core