Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP-5539: Revocation List Registry #5539

Merged
merged 10 commits into from
Sep 15, 2022
Merged

Add EIP-5539: Revocation List Registry #5539

merged 10 commits into from
Sep 15, 2022

Conversation

lleifermann
Copy link
Contributor

Signed-off-by: Lauritz Leifermann [email protected]

@lleifermann
add Revocation List Registry to EIPS
64c2644 
Signed-off-by: Lauritz Leifermann <[email protected]>
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 26, 2022 •
edited
Loading

A critical exception has occurred:
Message: pr 5539 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

Pandapip1
Pandapip1 reviewed Aug 26, 2022
View reviewed changes
EIPS/eip-template.md Outdated Show resolved Hide resolved
Pandapip1
Pandapip1 suggested changes Aug 26, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my first pass of this.

(FYI - the reason I'm being blunt/trite here is to avoid any unnecessary back and forth. This is me apologizing in advance since it's likely that my feedback might come off as rude if you're not used to it.)

EIPS/eip-template.md Outdated Show resolved Hide resolved
EIPS/eip-template.md Outdated Show resolved Hide resolved
EIPS/eip-template.md Outdated Show resolved Hide resolved
EIPS/eip-template.md Outdated Show resolved Hide resolved
EIPS/eip-template.md Outdated Show resolved Hide resolved
EIPS/eip-template.md Outdated Show resolved Hide resolved
EIPS/eip-template.md Outdated Show resolved Hide resolved
EIPS/eip-template.md Outdated Show resolved Hide resolved
@lleifermann
pull request review
fee25ff 
Signed-off-by: Lauritz Leifermann <[email protected]>
@github-actions github-actions bot added c-new Creates a brand new proposal t-erc" labels Aug 26, 2022
@lleifermann
Copy link
Contributor Author

Here's my first pass of this.

(FYI - the reason I'm being blunt/trite here is to avoid any unnecessary back and forth. This is me apologizing in advance since it's likely that my feedback might come off as rude if you're not used to it.)

Not at all! Thanks for you quick feedback on this. I've resolved most of your comments except the ethereum-magicians link (need to be allowed to post by a moderator first) and the Security Considerations Section. See my comments above.

@Pandapip1
Copy link
Member

The security considerations bit is my fault. Completely missed all the text under it.

@Pandapip1 Pandapip1 changed the title Revocation List Registry Add EIP-5539: Revocation List Registry Aug 28, 2022
Pandapip1
Pandapip1 reviewed Aug 28, 2022
View reviewed changes
EIPS/eip-5539.md Outdated Show resolved Hide resolved
@Pandapip1 Pandapip1 removed the t-erc" label Aug 28, 2022
@github-actions github-actions bot added s-draft This EIP is a Draft t-erc labels Aug 29, 2022
@fermentfan
Copy link
Contributor

Added the discussion link now with a topic created on my account.

@eth-bot eth-bot enabled auto-merge (squash) August 29, 2022 21:04
@eth-bot eth-bot enabled auto-merge (squash) September 12, 2022 12:47
eth-bot
eth-bot previously approved these changes Sep 12, 2022
View reviewed changes
auto-merge was automatically disabled September 12, 2022 13:11

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) September 12, 2022 13:12
@strumswell
Copy link
Contributor

Please fix all the internal links

They should be fixed now!

eth-bot
eth-bot previously approved these changes Sep 12, 2022
View reviewed changes
auto-merge was automatically disabled September 12, 2022 14:17

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) September 12, 2022 14:19
eth-bot
eth-bot previously approved these changes Sep 12, 2022
View reviewed changes
auto-merge was automatically disabled September 12, 2022 14:28

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) September 12, 2022 14:29
eth-bot
eth-bot previously approved these changes Sep 12, 2022
View reviewed changes
auto-merge was automatically disabled September 12, 2022 14:35

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) September 12, 2022 14:36
@strumswell
Copy link
Contributor

@Pandapip1 can you re-review so we can get this merged?

@eth-bot eth-bot merged commit 76e7aa1 into ethereum:master Sep 15, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
@lleifermann @fermentfan
@strumswell @nachomazzara
Add EIP-5539: Revocation List Registry (ethereum#5539)
91a0974 
* add Revocation List Registry to EIPS

Signed-off-by: Lauritz Leifermann <[email protected]>

* fix category & move definitions section to specification

Signed-off-by: Lauritz Leifermann <[email protected]>

* pull request review

Signed-off-by: Lauritz Leifermann <[email protected]>

* chore: add discussion link

* chore: reflect newest changes to functions, events, and fix link issue

* chore: fix links for nonce and signed hash

* chore: add signer addresses to signed methods

* chore: remove old batch event

* chore: missing comma

Signed-off-by: Lauritz Leifermann <[email protected]>
Co-authored-by: Dennis von der Bey <[email protected]>
Co-authored-by: Philipp Bolte <[email protected]>
Co-authored-by: Philipp Bolte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fermentfan fermentfan fermentfan left review comments

@strumswell strumswell strumswell left review comments

@xinbenlv xinbenlv xinbenlv left review comments

@eth-bot eth-bot eth-bot approved these changes

@Pandapip1 Pandapip1 Pandapip1 approved these changes

Assignees
No one assigned
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lleifermann @eth-bot @Pandapip1 @fermentfan @strumswell @xinbenlv