Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-1: Add License Checker #5379

Closed
wants to merge 18 commits into from
Closed

Update EIP-1: Add License Checker #5379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
51a20de
Add license checker
Pandapip1 Jul 30, 2022
12f8113
Voilà
Pandapip1 Jul 31, 2022
533d083
O o p s
Pandapip1 Jul 31, 2022
bdc1bcb
Add a bunch of exceptions, because nothing is perfect
Pandapip1 Jul 31, 2022
7534f97
Or I thought I had made that change
Pandapip1 Aug 1, 2022
d261332
If it works don't fix it
Pandapip1 Aug 1, 2022
51dcb81
Bug :P
Pandapip1 Aug 1, 2022
f045a7a
Remove exceptions
Pandapip1 Aug 1, 2022
7f275ac
Quick EIP-1 modification
Pandapip1 Aug 1, 2022
b56fac8
Merge branch 'ethereum:master' into patch-2
Pandapip1 Aug 3, 2022
0f41e29
You asked for it
Pandapip1 Aug 4, 2022
43e3066
Merge branch 'ethereum:master' into patch-2
Pandapip1 Aug 11, 2022
fa04c9c
Update EIPS/eip-1.md
Pandapip1 Aug 12, 2022
d342bfb
Merge branch 'master' into patch-2
Pandapip1 Aug 12, 2022
f8ee6d1
Merge branch 'master' into patch-2
Pandapip1 Aug 28, 2022
c8df641
Allow bypass
Pandapip1 Oct 19, 2022
984ce97
Merge branch 'master' into patch-2
Pandapip1 Jan 18, 2023
7568e6d
testing: does this syntax work
Pandapip1 Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,21 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
unchecked: 1, 5069, 5757

check-license-lines:
name: Check licenses
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b

- name: Delete Unchanged Files
id: changed-files
uses: Pandapip1/delete-unchanged-files@0937c94da2e9f9f262bbf2035e75065a1fd04bcf

- name: Check License Lines
uses: kt3k/license_checker@d12a6d90c58e30fefed09f2c4d03ba57f4c673a8
continue-on-error: true

markdownlint:
name: Markdown Linter
runs-on: ubuntu-latest
Expand Down
5 changes: 5 additions & 0 deletions .licenserc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"**/*.{sol}": [
"// SPDX-License-Identifier: CC0-1.0"
]
}
2 changes: 1 addition & 1 deletion EIPS/eip-1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ References to other EIPs should follow the format `EIP-N` where `N` is the EIP n

## Auxiliary Files

Images, diagrams and auxiliary files should be included in a subdirectory of the `assets` folder for that EIP as follows: `assets/eip-N` (where **N** is to be replaced with the EIP number). When linking to an image in the EIP, use relative links such as `../assets/eip-1/image.png`.
Images, diagrams and auxiliary files should be included in a subdirectory of the `assets` folder for that EIP as follows: `assets/eip-N` (where **N** is to be replaced with the EIP number). When linking to an image in the EIP, use relative links such as `../assets/eip-1/image.png`. These files must be released into the public domain (or as close as is legally possible) using [CC0](../LICENSE.md). Solidity files must use the SPDX Identifier `CC0-1.0`.
Copy link
Contributor

@xinbenlv xinbenlv Sep 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to agree with the requirement for asset file to be CC-0, but only on condition of that the reference implementation don't have to live in ethereum/EIPs repository if author don't want to grant a CC0 license for a reference implementation. We shall give author such options.

Copy link
Member Author

@Pandapip1 Pandapip1 Sep 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree. We should definitely force authors to use CC0 if they legally can, since it means that users don't have to worry about attribution and all that stuff that just can't apply to blockchains. If they legally can't use CC0, then and only then will we allow non-CC0 assets. But we will allow them if they are open-source enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that "as close as is legally possible" is opening the door for a fair bit of conflict in the future. Now editors need to verify claims from authors that "this is the best license I can give this!1!!".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... we don't necessarily need to verify those claims. Depending on how restrictive the license is, we can, well, not approve the PR.


## Transferring EIP Ownership

Expand Down