-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-1: Reference ERCs by ERC-X #5273
Conversation
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): (fail) eip-1.md
|
We should turn off EIPW for EIP-1. I don't particularly care on this one either, I'll defer to others. |
Done in #5278 |
As one of the main proponents for referring to EIPs in the ERC category, I'm a 👍 on this. |
Pull request was closed
Pull request was closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am once again reiterating my dislike for this change 🤣
If we're determined to go ahead with it, I prefer this wording.
Co-authored-by: Sam Wilson <[email protected]>
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
@lightclient are you still happy with these changes? |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
I think this is still something @lightclient and @gcolvin want |
We really need to do this. Many people in the community are becoming confused by our backtracking of ERC => EIP. |
Just for the record, I am not a fan of this idea, as I think that all other Standard Track EIPs are still documented as EIP and so should be Standard Track ERC. Community are free to call EIP-20 or ERC-20 as per their convenience. However, if people agree to go with changing the documentation in EIP-1 as ERC-x, I'd like to see the change in the .md file of respective proposals to avoid confusion. |
As promised, here's the I'm still opposed. |
Documenting discussion: this issue was discussed on EIPIP Meeting 69. The resolution is
@poojaranjan and everyone correct me if I was wrong |
I am also -0 (not in favor, but not blocking). |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
Dismissing stale bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😾
* Make ERCs referenced as ERC-X * While I'm at it, change should to must * Make the two sentences a bit more similar * Rephrase * The bike shed has been built Co-authored-by: Sam Wilson <[email protected]> --------- Co-authored-by: Sam Wilson <[email protected]>
Changes EIP-1 to force ERCs to be referenced as
ERC-X
instead ofEIP-X
.NOTE: I honestly don't actually care if this change is implemented (in fact, I lean slightly towards keeping ERC references as
EIP-X
). I am just making this PR so that the appropriate action can be taken immediately once a consensus is reached.